test(inspector): typecheck its own tests - #528
Merged
Merged
Conversation
The last package whose `typecheck` compiled only `src/**`. Its 31 test files were never type-checked; they compile clean once in scope, so this is coverage with no fixes attached. `tsconfig.test.json` matches the one every other package now carries, and the lint script picks the new file up alongside the tsconfigs it already covers. With this, every workspace package that has tests type-checks them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last package whose
typecheckcompiled onlysrc/**. Its 31 test files were never type-checked.They compile clean once in scope, so this is coverage with nothing to fix —
tsconfig.test.jsonmatching the one every other package now carries, plus the lint script picking the new file up alongside the tsconfigs it already covers.With this, every workspace package that has tests type-checks them. The sweep that started with the root
test/tree in #501 is closed.Verification
pnpm lintpnpm typecheckpnpm testnode scripts/check-docs.mjstsc --listFilesconfirms the 31 test files are actually in scope rather than silently skipped, and an injectedTS2322in a test file is caught by the equivalent config — the configs check, they don't just pass.Note for reviewers
permissions,sdk,langchainandcorealready landed their owntsconfig.test.jsonon main while this was in flight, so they are deliberately untouched here. This PR isinspectoronly.🤖 Generated with Claude Code